Comments on: Performance Patch for Propel im symfony

By: Bert-Jan

Bert-Jan — Thu, 10 Jan 2008 21:44:03 +0000

Correction: the includes in the subclasses are also gone. They were just some files from Propel 1.2 that 1.3 didn’t replace when I installed the plugin and ran propel-13-build-model.

By: Bert-Jan

Bert-Jan — Wed, 09 Jan 2008 08:59:54 +0000

I’m using Propel 1.3 in my current project and with addIncludes set to false the includes in the base classes are actually gone. I haven’t tested to see where the include is put when addIncludes is turned on.
The include statement at the top of the subclasses (under model/) is still there though.

By: Sinon

Sinon — Thu, 11 Oct 2007 14:43:00 +0000

yeah, I always used the first, because it’s the same entity, and unless it is modified from call to call, its faster either way.. I think its just better coding..

By: Thierry

Thierry — Thu, 11 Oct 2007 09:09:30 +0000

Definitely they should have placed the include in the if statement. Good fix!
Which version of Propel has this problem?

By: Fabian

Fabian — Thu, 11 Oct 2007 09:09:04 +0000

Hi Eric,
thanks for your comment. you are right. If used with standard autoloading in symfony the call is not required at all. But this is propel generated code. Which, I assume, should work also outside symfony. so from that the cleanest solution is to keep the include, just put it where it is absolutely needed.

But perhaps thats a good idea for an improvement the code compacter. It already removes comments to reduce the file size. It could also remove the include_once calls

By: Eric

Eric — Thu, 11 Oct 2007 08:13:20 +0000

Hello

I think you can remove this include_once call thank to symfony’s autoloading system

Just take a look at the config_autoload.yml.php file in the cache directory and you will see that every class defined in your model is registered in this file.